Skip to content

cleanup: Bump microsoft/wmi to 0.34.0 containing WMI method call fix #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

cleanup: Bump microsoft/wmi to 0.34.0 containing WMI method call fix #394

merged 1 commit into from
Jul 14, 2025

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Jul 3, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The WMI method call fix is released with microsoft/wmi @ 0.31.2.
This PR bumps this library and remove the workaround.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 3, 2025
@laozc laozc changed the title Bump microsoft/wmi to 0.31.2 containing WMI method call fix cleanup: Bump microsoft/wmi to 0.31.2 containing WMI method call fix Jul 3, 2025
andyzhangx
andyzhangx reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
@andyzhangx
Copy link
Member

@laozc can you make similar change in azure disk and file csi driver repos? I think that would verify easily since those two drivers has e2e tests to cover, thanks.

@laozc
Copy link
Contributor Author

laozc commented Jul 3, 2025

Sure. Let me work on the changes on those drivers and use them for E2E coverage.

@laozc laozc force-pushed the bump-wmi branch 6 times, most recently from 3fd5d39 to b76a8ec Compare July 10, 2025 06:16
@laozc laozc changed the title cleanup: Bump microsoft/wmi to 0.31.2 containing WMI method call fix cleanup: Bump microsoft/wmi to 0.34.0 containing WMI method call fix Jul 10, 2025
@laozc laozc force-pushed the bump-wmi branch 9 times, most recently from 4e5f762 to e1bfc80 Compare July 10, 2025 12:35
@laozc laozc force-pushed the bump-wmi branch 4 times, most recently from b34179a to 9a25274 Compare July 11, 2025 09:45
andyzhangx
andyzhangx approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, laozc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit dfdea98 into kubernetes-csi:master Jul 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laozc @k8s-ci-robot @andyzhangx